Skip to content

Migrate deprecated gopkg.in/yaml.v3 to go.yaml.in/yaml/v3#3865

Merged
openshift-merge-bot[bot] merged 2 commits into
operator-framework:masterfrom
chimanjain:deps/migrate-yaml-v3
Jul 15, 2026
Merged

Migrate deprecated gopkg.in/yaml.v3 to go.yaml.in/yaml/v3#3865
openshift-merge-bot[bot] merged 2 commits into
operator-framework:masterfrom
chimanjain:deps/migrate-yaml-v3

Conversation

@chimanjain

@chimanjain chimanjain commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description of the change:
Migrate deprecated gopkg.in/yaml.v3 to go.yaml.in/yaml/v3 from direct dependenies.
Reference: https://github.com/yaml/go-yaml

Motivation for the change:
The gopkg.in domain is deprecated and the yaml project has moved to go.yaml.in.
This ensures continued updates and security patches.

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Copilot AI review requested due to automatic review settings July 11, 2026 04:33
@openshift-ci
openshift-ci Bot requested review from joelanford and pedjak July 11, 2026 04:33
@openshift-ci

openshift-ci Bot commented Jul 11, 2026

Copy link
Copy Markdown

Hi @chimanjain. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 11, 2026
Copilot AI reviewed Jul 11, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Operator Lifecycle Manager (OLM) to use the newer go.yaml.in/yaml/v3 module path in place of the deprecated gopkg.in/yaml.v3, aligning local code with the YAML project’s domain migration.

Changes:

  • Updated YAML v3 imports from gopkg.in/yaml.v3 to go.yaml.in/yaml/v3 in the cpb utility and a catalog operator test.
  • Updated go.mod to add go.yaml.in/yaml/v3 v3.0.4 as a direct dependency and drop the direct gopkg.in/yaml.v3 requirement (though it remains indirect).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
util/cpb/main.go Switches YAML v3 import to the new go.yaml.in module path for bundle annotation parsing.
pkg/controller/operators/catalog/operator_test.go Switches YAML v3 import to go.yaml.in and includes gofmt formatting-only adjustments in tests.
go.mod Adds go.yaml.in/yaml/v3 as a direct requirement and adjusts YAML v3 dependency entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread go.mod
Comment on lines 193 to 196
gopkg.in/warnings.v0 v0.1.2 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
k8s.io/gengo/v2 v2.0.0-20250922181213-ec3ebc5fd46b // indirect

@chimanjain chimanjain Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is an indirect dependency which will be removedonce the direct dependencies migrate to the maintained yaml gomodule

@perdasilva perdasilva removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 14, 2026
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2026
@chimanjain
chore: migrate deprecated gopkg.in/yaml.v3 to go.yaml.in/yaml/v3
10c397a 
Signed-off-by: Chiman Jain <chimanjain15@gmail.com>
Copilot AI review requested due to automatic review settings July 15, 2026 10:08
@chimanjain
chimanjain force-pushed the deps/migrate-yaml-v3 branch from 3dd6dda to 10c397a Compare July 15, 2026 10:08
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2026
@chimanjain
chore: run go mod tidy
b392637 
Signed-off-by: Chiman Jain <chimanjain15@gmail.com>
Copilot AI reviewed Jul 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread go.mod
gopkg.in/natefinch/lumberjack.v2 v2.2.1 // indirect
gopkg.in/warnings.v0 v0.1.2 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect

@chimanjain chimanjain Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reran go mod tidy and then go mod vendor. The vendoring is consitent.

Comment thread go.mod
@tmshort

tmshort commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2026
@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit b0123be into operator-framework:master Jul 15, 2026
14 checks passed
@chimanjain
chimanjain deleted the deps/migrate-yaml-v3 branch July 16, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@rashmigottipati rashmigottipati rashmigottipati approved these changes
@joelanford joelanford Awaiting requested review from joelanford
@pedjak pedjak Awaiting requested review from pedjak

Assignees

@rashmigottipati rashmigottipati

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chimanjain @tmshort @rashmigottipati @perdasilva